Hello again,
How can I search in a file containing several lines for words that are themselves contained in another file??
Then I should put the word(s) (found) and the coresponding line, one by one, in a third file!



Thank you in advance!!

: Hello again,
: How can I search in a file containing several lines
: for words that are themselves contained in another file??
: Then I should put the word(s) (found) and the coresponding line, one
: by one, in a third file!
:
:
:
: Thank you in
: advance!!
:


Don't understand the problem. Would you please give us an example: what is in File #1 and File #2?

=============================================
never lie -- the government doesn't like the competition. (Author unknown)

: : Hello again,
: : How can I search in a file containing several lines
: : for words that are themselves contained in another file??
: : Then I should put the word(s) (found) and the coresponding line, one
: : by one, in a third file!
: :
: :
: :
: : Thank you in
: : advance!!
: :

:
:
: Don't understand the problem. Would you please give us an example:
: what is in File #1 and File #2?
:
: =============================================
: never lie -- the government doesn't like the competition. (Author
: unknown)

Let's say that:

FILE1:
"I am programming using C language
but I prefer Java
maybe php is my favorite"

FILE2:
" Java
using
php"
FILE 1 and 2 is given and I should produce:

FILE 3:
" Java = but I prefer Java
using = I am programming using C language
php = maybe php is my favorite "

Thank you again for your time, stober

:
: FILE1:
: "I am programming using C language
: but I prefer Java
: maybe php is my favorite"
:
: FILE2:
: " Java
: using
: php"
: FILE 1 and 2 is given and I should produce:
:
: FILE 3:
: " Java = but I prefer Java
: using = I am programming using C language
: php = maybe php is my favorite " [/size]
:
:


Oh! That makes sense now. Start out by reading File 1 into an array of strings to make it easier and faster to search.

Next, read each line of File 2. When read one line in File 2 search the array of strings read from File 1 for that text from File 2. The strstr() function will be helpful for that. When found save the info to File 3. I could give you the code, but I won't.
=============================================
never lie -- the government doesn't like the competition. (Author unknown)

: :
: : FILE1:
: : "I am programming using C language
: : but I prefer Java
: : maybe php is my favorite"
: :
: : FILE2:
: : " Java
: : using
: : php"
: : FILE 1 and 2 is given and I should produce:
: :
: : FILE 3:
: : " Java = but I prefer Java
: : using = I am programming using C language
: : php = maybe php is my favorite " [/size]
: :
: :
:
:
: Oh! That makes sense now. Start out by reading File 1 into an
: array of strings to make it easier and faster to search.
:
: Next, read each line of File 2. When read one line in File 2 search
: the array of strings read from File 1 for that text from File 2.
: The strstr() function will be helpful for that. When found save the
: info to File 3. I could give you the code, but I won't.
: =============================================
: never lie -- the government doesn't like the competition. (Author
: unknown)

Thank you,thank you,thank. I'll try to sort things out and I will post again if I have any problem!

: : :
: : : FILE1:
: : : "I am programming using C language
: : : but I prefer Java
: : : maybe php is my favorite"
: : :
: : : FILE2:
: : : " Java
: : : using
: : : php"
: : : FILE 1 and 2 is given and I should produce:
: : :
: : : FILE 3:
: : : " Java = but I prefer Java
: : : using = I am programming using C language
: : : php = maybe php is my favorite " [/size]
: : :
: : :
: :
: :
: : Oh! That makes sense now. Start out by reading File 1 into an
: : array of strings to make it easier and faster to search.
: :
: : Next, read each line of File 2. When read one line in File 2 search
: : the array of strings read from File 1 for that text from File 2.
: : The strstr() function will be helpful for that. When found save the
: : info to File 3. I could give you the code, but I won't.
: : =============================================
: : never lie -- the government doesn't like the competition. (Author
: : unknown)
:
: Thank you,thank you,thank. I'll try to sort things out and I
: will post again if I have any problem!
:

Can you please tell me how to read the files to a string? I can't seem to manage it!

:
: Can you please tell me how to read the files to a string? I can't
: seem to manage it!
:


post your code. It should go something like this

char iobuf[255];
FILE* fp = fopen("filename.txt","r");
if( fp != NULL)
{
   while( fgets(iobuf,sizeof(iobuf),fp) )
   {
        // do something here
   }
   fclose(fp);
}

=============================================
never lie -- the government doesn't like the competition. (Author unknown)

: :
: : Can you please tell me how to read the files to a string? I can't
: : seem to manage it!
: :
:
:
: post your code. It should go something like this
:

: 
: char iobuf[255];
: FILE* fp = fopen("filename.txt","r");
: if( fp != NULL)
: {
:    while( fgets(iobuf,sizeof(iobuf),fp) )
:    {
:         // do something here
:    }
:    fclose(fp);
: }
: 

:
:
: =============================================
: never lie -- the government doesn't like the competition. (Author
: unknown)



#include <stdio.h>

FILE* fin1;
FILE* fin2;
char buf1[500], buf2[500];
char arr1[500];
int i;

main()
{

fin1= fopen("c:\\b.txt","r");
fin2=fopen("c:\\c.txt","r");
if (fin1!=NULL)
{
while (fgets(buf1,sizeof(buf1),fin1) )

{ arr1[i]=buf1[i];

i++;}
fclose(fin1);
}

}

But it doesn't work this way?Pleazzz!What am id doing wrong?

: : :
: : : Can you please tell me how to read the files to a string? I can't
: : : seem to manage it!
: : :
: :
: :
: : post your code. It should go something like this
: :

: : 
: : char iobuf[255];
: : FILE* fp = fopen("filename.txt","r");
: : if( fp != NULL)
: : {
: :    while( fgets(iobuf,sizeof(iobuf),fp) )
: :    {
: :         // do something here
: :    }
: :    fclose(fp);
: : }
: : 

: :
: :
: : =============================================
: : never lie -- the government doesn't like the competition. (Author
: : unknown)
:
:
:
: #include <stdio.h>
:
: FILE* fin1;
: FILE* fin2;
: char buf1[500], buf2[500];
: char arr1[500];
: int i;
:
: main()
: {
:
: fin1= fopen("c:\\b.txt","r");
: fin2=fopen("c:\\c.txt","r");
: if (fin1!=NULL)
: {
: while (fgets(buf1,sizeof(buf1),fin1) )
:
: { arr1[i]=buf1[i];
:
: i++;}
: fclose(fin1);
: }
:
: }
:
: But it doesn't work this way?Pleazzz!What am id
: doing wrong?
:
You're not searching through the text file or saving the resulting array.

: : : :
: : : : Can you please tell me how to read the files to a string? I can't
: : : : seem to manage it!
: : : :
: : :
: : :
: : : post your code. It should go something like this
: : :

: : : 
: : : char iobuf[255];
: : : FILE* fp = fopen("filename.txt","r");
: : : if( fp != NULL)
: : : {
: : :    while( fgets(iobuf,sizeof(iobuf),fp) )
: : :    {
: : :         // do something here
: : :    }
: : :    fclose(fp);
: : : }
: : : 

: : :
: : :
: : : =============================================
: : : never lie -- the government doesn't like the competition. (Author
: : : unknown)
: :
: :
: :
: : #include <stdio.h>
: :
: : FILE* fin1;
: : FILE* fin2;
: : char buf1[500], buf2[500];
: : char arr1[500];
: : int i;
: :
: : main()
: : {
: :
: : fin1= fopen("c:\\b.txt","r");
: : fin2=fopen("c:\\c.txt","r");
: : if (fin1!=NULL)
: : {
: : while (fgets(buf1,sizeof(buf1),fin1) )
: :
: : { arr1[i]=buf1[i];
: :
: : i++;}
: : fclose(fin1);
: : }
: :
: : }
: :
: : But it doesn't work this way?Pleazzz!What am id
: : doing wrong?
: :
: You're not searching through the text file or saving the resulting
: array.
:
How do I do that Please?

: : : : :
: : : : : Can you please tell me how to read the files to a string? I can't
: : : : : seem to manage it!
: : : : :
: : : :
: : : :
: : : : post your code. It should go something like this
: : : :

: : : : 
: : : : char iobuf[255];
: : : : FILE* fp = fopen("filename.txt","r");
: : : : if( fp != NULL)
: : : : {
: : : :    while( fgets(iobuf,sizeof(iobuf),fp) )
: : : :    {
: : : :         // do something here
: : : :    }
: : : :    fclose(fp);
: : : : }
: : : : 

: : : :
: : : :
: : : : =============================================
: : : : never lie -- the government doesn't like the competition. (Author
: : : : unknown)
: : :
: : :
: : :
: : : #include <stdio.h>
: : :
: : : FILE* fin1;
: : : FILE* fin2;
: : : char buf1[500], buf2[500];
: : : char arr1[500];
: : : int i;
: : :
: : : main()
: : : {
: : :
: : : fin1= fopen("c:\\b.txt","r");
: : : fin2=fopen("c:\\c.txt","r");
: : : if (fin1!=NULL)
: : : {
: : : while (fgets(buf1,sizeof(buf1),fin1) )
: : :
: : : { arr1[i]=buf1[i];
: : :
: : : i++;}
: : : fclose(fin1);
: : : }
: : :
: : : }
: : :
: : : But it doesn't work this way?Pleazzz!What am id
: : : doing wrong?
: : :
: : You're not searching through the text file or saving the resulting
: : array.
: :
: How do I do that Please?
:
You can put stuff onto a file using fputs.
As for searching it, the first step is to find all the words that are being searched for, and store them in an array of strings. Then, somehow actually look through the buffer for the words, and add the findings to file C.

: : : : : :
: : : : : : Can you please tell me how to read the files to a string? I can't
: : : : : : seem to manage it!
: : : : : :
: : : : :
: : : : :
: : : : : post your code. It should go something like this
: : : : :

: : : : : 
: : : : : char iobuf[255];
: : : : : FILE* fp = fopen("filename.txt","r");
: : : : : if( fp != NULL)
: : : : : {
: : : : :    while( fgets(iobuf,sizeof(iobuf),fp) )
: : : : :    {
: : : : :         // do something here
: : : : :    }
: : : : :    fclose(fp);
: : : : : }
: : : : : 

: : : : :
: : : : :
: : : : : =============================================
: : : : : never lie -- the government doesn't like the competition. (Author
: : : : : unknown)
: : : :
: : : :
: : : :
: : : : #include <stdio.h>
: : : :
: : : : FILE* fin1;
: : : : FILE* fin2;
: : : : char buf1[500], buf2[500];
: : : : char arr1[500];
: : : : int i;
: : : :
: : : : main()
: : : : {
: : : :
: : : : fin1= fopen("c:\\b.txt","r");
: : : : fin2=fopen("c:\\c.txt","r");
: : : : if (fin1!=NULL)
: : : : {
: : : : while (fgets(buf1,sizeof(buf1),fin1) )
: : : :
: : : : { arr1[i]=buf1[i];
: : : :
: : : : i++;}
: : : : fclose(fin1);
: : : : }
: : : :
: : : : }
: : : :
: : : : But it doesn't work this way?Pleazzz!What am id
: : : : doing wrong?
: : : :
: : : You're not searching through the text file or saving the resulting
: : : array.
: : :
: : How do I do that Please?
: :
: You can put stuff onto a file using
: f
: puts.
: As for searching it, the first step is to find all the words that
: are being searched for, and store them in an array of strings. Then,
: somehow actually look through the buffer for the words, and add the
: findings to file C.
:

As for searching it, the first step is to find all the words that
: are being searched for, and store them in an array of strings. Then,
: somehow actually look through the buffer for the words, and add the
: findings to file C.

I have understood that!!!I don't know how to store them in an array.That is the problem!! Thank you in advance once again!

:
: I have understood that!!!I don't know how to store them in an
: array.That is the problem!! Thank you in advance once again!
:


create an array of pointers and then fill that array with the words you want.

// create an array that will hold up to 255 words
// you can change 255 to whatever you want as long 
// as its big enough to hold all the words.  There are
// other ways to do this but this is the simplest
char *array[255] = {0};
// this is a counter that indicates the number of words in the above array.
int  NumWords = 0;

// Add a word to the array like this:  Assume variable buf
// is a character buffer that was read from a file

// allocate memory for the word
array[NumWords] = malloc( strlen(buf) + 1);
// copy word into the array
strcpy( array[NumWords], buf);
// bump counter
++NumWords;

=============================================
never lie -- the government doesn't like the competition. (Author unknown)

: create an array of pointers and then fill that array with the words
: you want.
:

: 
: // create an array that will hold up to 255 words
: // you can change 255 to whatever you want as long 
: // as its big enough to hold all the words.  There are
: // other ways to do this but this is the simplest
: char *array[255] = {0};
: // this is a counter that indicates the number of words in the above array.
: int  NumWords = 0;
: 
: // Add a word to the array like this:  Assume variable buf
: // is a character buffer that was read from a file
: 
: // allocate memory for the word
: array[NumWords] = malloc( strlen(buf) + 1);
: // copy word into the array
: strcpy( array[NumWords], buf);
: // bump counter
: ++NumWords;
: 
: 

:
: =============================================
: never lie -- the government doesn't like the competition. (Author
: unknown)


This is my code so far. I then try to use the strstr function to search -even one- line but it doesn't work. Can you help me find the error??

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

FILE* fin1;
FILE* fin2;
char buf1[500], buf2[500];
char *arr1[500]={0};
char *sol;
int i,counter,LineCounter;

main()
{
countwords =0;
fin1= fopen("c:\\d.txt","r");
fin2=fopen("c:\\e.txt","r");
if (fin1!=NULL)
{
while (fgets(buf1,sizeof(buf1),fin1) )
{ arr1[countwords] = malloc( strlen(buf1) + 1);
strcpy( arr1[counter], buf1);
++counter;
} //assigned the first file to an array

for(i=0;i<countwords;i++) //show the array of file1
printf("%s",arr1[i]);
printf("\n ");
if (fin2!=NULL)
{
while (fgets(buf2,sizeof(buf2),fin2) )

++LineCounter;
if (LineCounter!=4){
{
for (i=0;i<4;i++){
sol=strstr(buf2,arr1[i]);
printf("%s",sol); } }

if( sol == NULL ) printf( "Could not find %s in '%s' ",arr1[0], arr2[0] );
printf( "Found a substring: '%s'\n", sol );

Is't strstr supposed to stop in '\0'. How I will search the whole phrase??

Thanks A MILLION!!!

:

: while (fgets(buf2,sizeof(buf2),fin2) )
: 	
:   	++LineCounter;
: 			if (LineCounter!=4){
: 		{          
:                             for (i=0;i<4;i++){       
:                             sol=strstr(buf2,arr1[i]);
:                             printf("%s",sol);  }                     
:                 }
: 

The problem is the above code is wrong.  You don't need LineCounter
 variable because you already have counter variable when the first file 
was read.  After reading a line from the second file you have to loop
 through all the lines that were read from the first file, your code is
 only looking at the first 4 lines and hopefully there are at least 4 lines.

while (fgets(buf2,sizeof(buf2),fin2) )
{
   for(i = 0; i < counter; i++)
   {
      if( (sol=strstr(buf2,arr1[i])) != NULL)
      {
            printf("Found it!\n");
      }
   }
}



I hope you realize that using the variable i above will destroy the 
value of the loop counter in the previous loop you coded.  I would suggest
 you just delete the previous loop using i counter because it serves no 
purpose to solving the solution to your problem.


=============================================
never lie -- the government doesn't like the competition. (Author unknown)

: :

: 
: : while (fgets(buf2,sizeof(buf2),fin2) )
: : 	
: :   	++LineCounter;
: : 			if (LineCounter!=4){
: : 		{          
: :                             for (i=0;i<4;i++){       
: :                             sol=strstr(buf2,arr1[i]);
: :                             printf("%s",sol);  }                     
: :                 }
: : 
: 
: The problem is the above code is wrong.  You don't need LineCounter
:  variable because you already have counter variable when the first file 
: was read.  After reading a line from the second file you have to loop
:  through all the lines that were read from the first file, your code is
:  only looking at the first 4 lines and hopefully there are at least 4 lines.
: 
: 
: 
: while (fgets(buf2,sizeof(buf2),fin2) )
: {
:    for(i = 0; i < counter; i++)
:    {
:       if( (sol=strstr(buf2,arr1[i])) != NULL)
:       {
:             printf("Found it!\n");
:       }
:    }
: }
: 
: 
: 
: 
: I hope you realize that using the variable i above will 
: destroy the 
: value of the loop counter in the previous loop you coded.  I would 
: suggest
:  you just delete the previous loop using i counter because it serves 
: no 
: purpose to solving the solution to your problem.
: 
: 
: =============================================
: never lie -- the government doesn't like the competition. (Author 
: unknown)


Thank you for that but even that way, the strstr doesn't work!!
It doesn't return anything ("Found it") even though the two files have common words!
while (fgets(buf2,sizeof(buf2),fin2) )
 	{
   	for(i = 0; i < counter; i++)
   {
      if( (sol=strstr(buf2,arr1[i])) != NULL)
      {
            printf("Found it!\n");
      }
   }

  Why is that???T-h-a-n-k y-o-u!

post a few lines from each file -- maybe strstr() is not what you need afterall, but impossible to say without seeing a little bit of each file.
=============================================
never lie -- the government doesn't like the competition. (Author unknown)

: post a few lines from each file -- maybe strstr() is not what you
: need afterall, but impossible to say without seeing a little bit of
: each file.
: =============================================
: never lie -- the government doesn't like the competition. (Author
: unknown)


This is a sample of 2 files I should produce the third.

FILE1:
: : "I am programming using C-language
: : but I prefer Java
: : maybe php is my favorite"
: :
: : FILE2:
: : "Java
: : using
: : php"
: :
: : FILE 3 (created by the program):
: : " Java = but I prefer Java
: : using = I am programming using C language


Please, any suggestions!! I got stuck here! Thank you!

you have a couple problems. First the contents of the files should not contain the quotes because the text "Java does not exist in the first file due to the leading quote.

Second, the function fgets() usually appends the CR/LF text record separator to the end of the string that is read in. So that needs to be stripped off before adding to the array and before using strstr(). After correcting the above problems and correcting program formatting style it works ok.

I also removed all global variables and made them local to main(). If you are using an ancient 16-bit compiler such as Turbo C you may not be able to do that due to limited stack size.

Variable buf2 was deleted because you can re-use buf1 and reduce memory requirements. You could have also used just one FILE pointer, but I didn't bother to change that.

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

char* readline(FILE* fp, char* inbuf, int bufsize)
{
// reads one line from a text file and strips off the 
// trailing '\n' if it exists.

    int length;
    if( fgets(inbuf,bufsize,fp) == NULL)
        return NULL;
    length = strlen(inbuf) - 1;
    if( inbuf[length] == '\n')
        inbuf[length] = 0;
    return inbuf;
}

int main()
{
    FILE* fin1;
    FILE* fin2;
    char buf1[500];
    char *arr1[500]={0};
    char *sol;
    int i,counter;

    counter =0;
    fin1= fopen("d.txt","r");
    fin2=fopen("e.txt","r");
    if (fin1!=NULL)
    {
        while ( readline(fin1,buf1,sizeof(buf1)) )
        { 
            arr1[counter] = (char*)malloc( strlen(buf1) + 1);
            strcpy( arr1[counter], buf1);
            ++counter;
        } //assigned the first file to an array
        fclose(fin1);
    }

    if (fin2!=NULL)
    {
        while (readline(fin2,buf1,sizeof(buf1)) )
        {
            for(i = 0; i < counter; i++)
            {
                if( (sol=strstr(arr1[i],buf1)) != NULL)
                {
                    printf("%s\n",arr1[i]);
                }   
            }
        }
        fclose(fin2);
    }
}

=============================================
never lie -- the government doesn't like the competition. (Author unknown)